Hook into Notifications Module

quick update.

I think I know what the problem is, modr8_form_submit() manually sets the status of the node to 1(published). However I noticed that when I manually published a node in admin, the notifications event fired and my emails were sent, looking thru code it looks like all we need to do is make modr8_form_submit() do a node_save() and it's all taken care of....

coding and testing, expect a patch hopefully soon.

That seems to do the job.

the problem was definitely because modr8 was manually setting the node.status field to 1. Core node module does this...

  node_invoke($node, $op);
  node_invoke_nodeapi($node, $op);

after saving node. I think that's the code that allows other modules to do their stuff, including Notifications.

Very simple fix...

function modr8_form_submit($form, &$form
         }
         $publish = '';
         if (user_access('administer nodes')) {
-          $publish = ', status = 1';
+          $node = node_load($nid);
+          $node->status = 1;
+          node_save($node);
         }
-        db_query('UPDATE {node} SET moderate = 0 '. $publish .' WHERE nid = %d', $nid);
+        db_query('UPDATE {node} SET moderate = 0 WHERE nid = %d', $nid);
         drupal_set_message(t('The %type with title %title has been approved.', array('%title' => $values['title'], '%type' => $values['type'])));
         cache_clear_all();
         modr8_log_action('approve', $nid, $values, $message);

I think I've made this mistake in one of my own bits of code so I'm off to check it now.

Obviously, please test this yourself before applying to a live site. Patch is against 6.x-1.1

@pwolanin

looks like you can drop the line;

 }
         $publish = '';   <-- drop this line !!?
+        $node = node_load($nid);

$publish doesn't seem to be used anywhere else in the function and it doesn't look like it's a global.