See title :)

There are currently some test failures on PostgreSQL, I need to figure out why and resolve them.

CommentFileSizeAuthor
#2 fix_pgsql_tests.patch2.48 KBBerdir
#1 pgsql_fixes.patch1.75 KBBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Version: 6.x-1.x-dev »
Status: Active » Needs review
FileSize
pgsql_fixes.patch1.75 KB

Hm...

I don't understand why this only fails on PostgreSQL, but because we don't order by mid, the message list might not be in the order we're expecting.

The same for the participants, which aren't ordered at all. I'm currently ordering them by UID, I don't like that but PostgreSQL doesn't allow sorting by MID (In there order the participated in the thread). Maybe name but that would break the tests too :)

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
FileSize
fix_pgsql_tests.patch2.48 KB

Ok, to avoid changing too much, I've decided to simply remove the problematic assertion.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Fixed

Commited and fixed in all branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.