Follow-up from #609128: Dashboard should provide feedback when clicking "Done" after it was discovered that Taxonomy module says Your configuration has been saved. after its configuration has been saved, while we use The configuration options have been saved. virtually everywhere else. So let us use The configuration options have been saved. in taxonomy.admin.inc as well.

CommentFileSizeAuthor
#7 taxonomy_save_message.patch1.76 KBergonlogic
#1 taxonomy_save_message.patch960 bytesergonlogic

Comments

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
StatusFileSize
new taxonomy_save_message.patch960 bytes

This ought to do it.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Status: Active » Needs review

Status: Needs review » Needs work
Issue tags: -Novice

The last submitted patch, taxonomy_save_message.patch, failed testing.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Status: Needs work » Needs review

#1: taxonomy_save_message.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice

The last submitted patch, taxonomy_save_message.patch, failed testing.

Freso’s picture

Freso commented

Hm. It looks like you'll need to ForumTestCase->doAdminTests() as well, as that expects to see Your configuration has been saved. - which is why the test fails. But looking good otherwise. :)

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
StatusFileSize
new taxonomy_save_message.patch1.76 KB

@Freso: Thanks for the feedback and pointer. I figured it might be something like that. I see now where qa.drupal.org points to the specific function where the error occurred.

I've now patched the forum test to match the changes in taxonomy.

Freso’s picture

Freso commented
Status: Needs work » Needs review

Looking good. If the test bot's happy, I'm happy. :)

Freso’s picture

Freso commented
Status: Needs review » Reviewed & tested by the community

Test bot says go, I say go.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Novice

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.