artico [artico]

Hello, and thanks for applying for a CVS account.

As per Apply for contributions CVS access, the motivation message must be expanded.

See the previous comment: As per Apply for contributions CVS access, the motivation must be expanded, and describe the features present in the proposed module, and compare it with the existing projects.

Files available from third-party site need to be removed.

Third-party files are still included in the archive.

  require_once('mooha_server.helper');

There is a Drupal functions to call in such cases. The current directory set by Drupal is the Drupal root directory, which is not the directory containing the module; require_once() would not find the file passed as argument. Anyway, calling the correct Drupal function, the problem of the directory set as current directory would not be a problem.

I am talking of the files in the directory mooha, which are available from http://mooha.net/; third-party files means files available from third-party sites, which are all the sites external to Drupal.org.

The files that are in the directory mohaa must be kept separated, and not included together the module files; users should be instructed on where to download the extra files, and where to copy them.

That is explained in 3rd party libraries in Drupal CVS; the content of the directory mohaa is considered third-party libraries.

1. /**
    * Copyright (c) 2009 Madcap BV (http://www.madcap.nl)
    * All rights reserved.
    *
    * Permission is granted for use, copying, modification, distribution,
    * and distribution of modified versions of this work as long as the
    * above copyright notice is included.
    */
   

   I am not sure if what reported in that comment is compatible with GPL License v2+ used by Drupal, and that is valid for any code committed in Drupal.org repositories.

2.     if (substr(VERSION, 0, 1) == 6) {
         $user = user_load(array('name' => $userName, 'pass' => $userPassword, 'status' => 1));
         return $user === FALSE ? 0 : $user->uid;
       }
   

   As the module is for Drupal 6, the condition will always be verified; it's useless to check that.

Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Maybe this should be checked by Crell.

@artico: Thanks for reporting here the latest revised version. Your CVS account should be already working; if it is not, please report that here.

Copyright statements of that sort are not allowed in CVS. All rights are not, in fact, reserved. :-) Also, the permission block listed there is more permissive than the GPL, which is not allowed.

We actually ask that you not include any copyright statement in the header. As you start accepting patches the copyright ownership will become shared by various people, so saying that it's all copyright one person will be inaccurate. Additionally, should Drupal ever move to GPLv3 we don't want to have to go through and change (or ask people to change) all such headers. That's why nearly all modules on Drupal.org have no in-file copyright statement and rely on the auto-included LICENSE.txt file.

The account has been already approved; there is no more need to review code.