In some cases, $item['tid'] can be NULL, just needs a check for !empty(). Patch via chx with minor modification from me.

CommentFileSizeAuthor
#2 term.patch867 bytescatch
term.patch866 bytescatch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, term.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs work » Needs review
FileSize
term.patch867 bytes

*whistles*

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs review » Reviewed & tested by the community

Verified and validated.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

This means we're missing test coverage for whatever chunk calls this code. Suggestions?

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

Hmm.. When does this happen? I think it happens when the term referenced by the field value has been deleted.

Does the test need to create entities that refer to the term, delete the term and then attempt to render these entities?

chx’s picture

chx CreditAttribution: chx commented

You need to set the parent to a nonexisting tid in the field definition.

marthinal’s picture

marthinal CreditAttribution: marthinal commented
Status: Needs work » Needs review
Issue tags: -Needs tests

term.patch queued for re-testing.