HS Taxonomy Views + Views 3 + taxonomy term filter: You have an error in your SQL syntax

hai and hello

i've exact the same problem as trupal218
by uising views and taxonomie filter and autocomplete

user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1 query: SELECT * FROM term_data td WHERE td.tid IN () in var\www\drupal6\sites\all\modules\views\modules\taxonomy\views_handler_filter_term_node_tid.inc on line 295.

any suggestions?

thnaxx

trupal218: Can you make a step by step report?

Then fixing would be trivial, i think. Thanks!

@dereine - please let me know if this is enough information to troubleshoot this.

And i appreciate your incredible awesome bug repots. Compared to nearly every other issue its much much much better. Really you do it perfect.

I reproduced it step by step, but there is still no error. The good thing is that this error messsage can only be seen by the administration. Could you expose the view? Perhaps there is a space or something like this.

Oh cool, so this is fixed now.

(Moving back to the Views issue queue temporarily to get some feedback on how to fix this.)

dereine, I have no clue where to begin looking for the cause. Why does a Views plugin that works just fine with Views 2 all of a sudden stop working with Views 3? And especially: how could it cause an SQL error?

The code should read like butter to you: all I do, is subclassing views_handler_filter_term_node_tid. I override 7 methods (it's less than 250 lines of code, with probably over half of it comments). It must be the exposed input handling that has changed and that's therefore triggering this problem — because only when the accept_exposed_input method returns true, Views will alter the query, based on the input set by Hierarchical Select.

I'd appreciate your pointers here :) — I don't think there's Views 2 API -> Views 3 API upgrade documentation available? If there is, I could not find it.

What does your widget return if there is no term selected?

  function admin_summary() {
    // set up $this->value_options for the parent summary
    $this->value_options = array();

    if ($this->value) {
      $result = db_query("SELECT * FROM {term_data} td WHERE td.tid IN ("  . implode(', ', $this->value) . ")");

      while ($term = db_fetch_object($result)) {
        $this->value_options[$term->tid] = $term->name;
      }
    }
    return parent::admin_summary();
  }

I think $this->value is not an array, as views expect it to be. I don't know what the value is here, but it could be a multi-dimensional array.

subscribing

subscribing.

I have the same issue but with views 2

exposed filter with autocomplete on a taxonomy term id - selecting a simple one level vocabulary that doesn't have HS activated.

when I disable HS the error goes away.

this is very strange since this shouldn't have anything to do with HS.

Idan

I would really like to use Hierarchical Select with Views, but unfortunately this means that I will have to disable it to prevent the error.

I should also mention, that I get the error in the same way as the OP, except I am using Autocomplete with Term ID (but also exposed).

Please help! Thanks!

Subscribe?

Does this problem still exist in 3.5?

Yes, I had this problem after setting up the label on a taxonomy views filter made with a HS widget.

I don't have time to look into this. I'll happily review & commit a patch that fixes this :)

Not critical, but minor because it appears to bother very few users.

Regarding #10: $this->value is always an array, since this is the code:

  function admin_summary() {
    $this->value = (array) $this->value;
    return parent::admin_summary();
  }

So, to debug the problem, I'll need some user that is experiencing this problem to 1) install and enable the devel module, 2) apply the attached patch, 3) try to reproduce the problem, 4) report back the output generated by this patch.

I had the same problem and got two empty arrays on screen.

Array
(
    [0] => 
)
Array
(
    [0] => 
)

So I added the line:

$this->value = $this->value[0];

after the typecast to array that Wim just pointed out in #18.
The errors are gone, all seems to work.

subscribing +1

subscribing.

subscribing...

I'm using Views 2, HS 6.x-3.7 and Drupal 6.13. #19 fixed the issue for me.

Hi everybody,

Same issue with View2 and Hierarchical Select.

So I just created this patch (in SVN format) related to the #19 tips, wich has fix the problem for me.
Very big thanks to ifitri !!!

Best regards,

6.x issue without activity for over 3 years, closing.

Please reopen if this is still an issue in 7.x.