I am aware of http://drupal.org/node/512086 but I think its not related. People are reporting to see the "Restricted node" message when adding nodes.

This issue is about them showing up in the queue itself

http://screencast.com/t/NDA5NTRi

I am logged in as a user that can edit the nodes (when clicking on the same link as on the screenshot) so I don't see a reason why it says "restricted node".

Regards, Tom

PS If necessary I can give remote access to my machine to reproduce. Just drop me a line. My timezone is CET

CommentFileSizeAuthor
#21 nodequeue-show-restricted-titles-719426.patch1.48 KBoknate
#18 719426-18-D6.patch876 bytesslip
#18 719426-18.patch406 bytesslip
#15 719426-15-D6.patch944 bytesamateescu
#15 719426-15.patch593 bytesamateescu
#11 nodequeue-719426-10.patch820 bytesfuerst
#9 nodequeue-719426-9.patch712 bytesfuerst
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

buckley’s picture

buckley CreditAttribution: buckley commented

For now I am going to try to give my webmasters more rights since I noticed that user 1 does not have the problem.

buckley’s picture

buckley CreditAttribution: buckley commented

Adding the permission "administer nodes" solves the problem for people looking for a workaround.

Note that this is only a temporary solution and should be thought over.

ezra-g’s picture

ezra-g CreditAttribution: ezra-g commented
Category: bug » support
Priority: Critical » Normal
Status: Active » Postponed (maintainer needs more info)

Sorry that you're having this problem.
A) Do you have any other node access modules installed?
B) Does the problem persist if you do a node access rebuild at admin/content/node-settings ?

mule77’s picture

mule77 CreditAttribution: mule77 commented

I have the same problem

>A) Do you have any other node access modules installed?
I have TAC installed and I have 2 role one with edit_own_content and another with edit_all_content,
even if the user has the privilege edit_all_content he sees the message "restricted node" for the nodes created by the other user
no one has the privilege "administer nodes"

>B) Does the problem persist if you do a node access rebuild at admin/content/node-settings ?
yes

mule77’s picture

mule77 CreditAttribution: mule77 commented
Version: 6.x-2.5 » 6.x-2.9
planctus’s picture

planctus CreditAttribution: planctus commented

I can confirm this.
This happens when users with "queue manipulation" permission do not have also the "administer nodes" one.
When they look at the queue all the nodes titles are in the form of "Restricted nodes nid: ".
Is there any solution already implemented for this? I mean...other than giving "administer node" permission...
I've tried both the 2.9 and 2.x-dev versions.
Thanks,
Da.

Naiya’s picture

Naiya CreditAttribution: Naiya commented

Hi, i have the same problem but i realized that it was because of the language.. my users are able to operate on nodes in every language but in queue they see nodes titles in current language, others are restircted (i can still edit and remove them) - when i switch to my second language - i see "Restricted" normally but those 'normal' nodes as restricted ;)

it looks like a bug to me.

Naiya’s picture

Naiya CreditAttribution: Naiya commented
Status: Postponed (maintainer needs more info) » Needs review

in function: nodequeue_nids_visible:

$query_restricted = db_query(db_rewrite_sql("SELECT DISTINCT(n.nid) ...
When i remove db_rewrite_sql i have no more problems with restricted nodes, but i'm not sure if removing it is a good idea...?
on the other hand it makes my non-current-language nodes restricted for my non-admin users (it is really not cool).

I'll be glad if maintainer look at it.

fuerst’s picture

fuerst CreditAttribution: fuerst commented
Version: 6.x-2.9 » 6.x-2.10
FileSize
nodequeue-719426-9.patch712 bytes

I do have the problem when using i18n. It will rewrite the query by adding the current active language which will just Restrict all nodes that belong to another language. You can verfy this by switching to another language at the same admin page.

Adding the language to the query can be disabled by setting i18n_selection_mode('off'). It's not nice to pollute the code by fragments like this. My feeling is that should be fixed in the i18n module: It must stop rewriting at /admin pages completely just like it does in its submodule i18ntaxonomy.

Nevertheless see the attached patch for the fix.

Status: Needs review » Needs work

The last submitted patch, nodequeue-719426-9.patch, failed testing.

fuerst’s picture

fuerst CreditAttribution: fuerst commented
Status: Needs work » Needs review
FileSize
nodequeue-719426-10.patch820 bytes

This patch restricts i18n_selection_mode('off') to admin pages because it is actually needed there only (I guess).

Status: Needs review » Needs work

The last submitted patch, nodequeue-719426-10.patch, failed testing.

fuerst’s picture

fuerst CreditAttribution: fuerst commented
Status: Needs work » Needs review

Checked the details of the test result but have no glue what it will tell me. Seems to be unrelated to the patch.

feuillet’s picture

feuillet CreditAttribution: feuillet commented
Status: Needs review » Reviewed & tested by the community

Patch works well here. Thank you.

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Version: 6.x-2.10 » 6.x-2.x-dev
Category: support » bug
Status: Reviewed & tested by the community » Fixed
FileSize
719426-15.patch593 bytes
719426-15-D6.patch944 bytes

Allright, checked how various i18n submodules use that function, and I commited to 6.x-2.x a slightly modified patch that also restores that selection after our query.

Fortunately, the patch for 7.x-2.x was a lot simpler thanks to DBTNG :)

Commited attached patches to 6.x-2.x and 7.x-2.x. Thanks!

http://drupalcode.org/project/nodequeue.git/commit/bd9c8c7
http://drupalcode.org/project/nodequeue.git/commit/4fd425b

fuerst’s picture

fuerst CreditAttribution: fuerst commented
Status: Fixed » Needs work

You are right: forgot to reset the language selection.

Small typo in the D6 patch though: It's called i18n_selection_mode('reset'); not i18n_selection_mode('resest');

Thanks anyway for submitting!

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs work » Fixed

Thanks for noticing, fixed :)

http://drupalcode.org/project/nodequeue.git/commit/ccd0e09310ee8620b2abf...

slip’s picture

slip CreditAttribution: slip commented
Status: Fixed » Needs review
FileSize
719426-18.patch406 bytes
719426-18-D6.patch876 bytes

Can we also apply this to autocomplete so you can add these nodes to the queue?

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs review » Fixed

Of course :) Thanks for the patches!

Commited to 6.x-2.x and 7.x-2.x.

http://drupalcode.org/project/nodequeue.git/commit/eddbe63
http://drupalcode.org/project/nodequeue.git/commit/9712bd4

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate commented
Version: 6.x-2.x-dev » 6.x-2.11
FileSize
nodequeue-show-restricted-titles-719426.patch1.48 KB

Here's a patch for the original subject of this thread, showing restricted titles to users who don't have access, and get rid of the annoying "Restricted node, NID" titles.

I created a variable setting to turn this on or off. I have no idea why you'd want to hide node titles, but someone must have thought that was useful. I create this patch to optionally show the titles, even if the user doesn't have 'administer nodes' access, the node isn't published, and the user isn't the creater of the node.