Unwittingly I used a string as the role I wanted to grant, instead of an array and got a foreach error. Some suggestions:

* Check for non-arrays if you are going to be doing a foreach
* Support a string
* Provide a default type in the function definition
* Better documentation

Thanks for the great module.

Comments

ebeyrent’s picture

ebeyrent commented
Assigned: Unassigned » ebeyrent

Ugh, that's embarrassing. You're absolutely correct - there needs to be better error checking.

Thanks for the feedback!

ebeyrent’s picture

ebeyrent commented
Status: Active » Fixed

Fixed in the 2.6 release

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.