ActionLoopTestCase is based on the assumption that ORDER BY timestamp returns log entry in the exact order of insertion, but that's not guaranteed, because this column has a one-second granularity.

On SQLite, this test fails, because it uses a different sorting algorithm then MySQL.

CommentFileSizeAuthor
#1 actions-loop.patch1.32 KBmr.baileys

Comments

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented
Status: Active » Needs review
StatusFileSize
new actions-loop.patch1.32 KB

Attached patch should do the trick (sort on wid since that should always be incremental, right?)

Also made a small documentation change in the number of iterations, left-over from #587634: Actions infinite loop test fails.

damien tournoud’s picture

damien tournoud commented
Status: Needs review » Reviewed & tested by the community

Yep. Thanks.

elijah lynn’s picture

elijah lynn
Location Portland, Oregon
commented

#1: actions-loop.patch queued for re-testing.

dries’s picture

dries commented

#1: actions-loop.patch queued for re-testing.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.