Error handling for invalid path [#71492]

Code in _gallery_init treats ERROR_MISSING_OBJECT to mean the user is not mapped into G2.. however, the same error is returned when URL rewrite is in use and an invalid path is given. Not sure if this is the best resolution, but the attached patch at least gets the right error into drupal watchdog for bad path.

Comment	File	Size	Author
#1	gallery_user.txt	590 bytes	Signe
	gallery_init_patch.txt	2.79 KB	mindless

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Signe CreditAttribution: Signe commented 19 February 2007 at 10:10

Version:	4.7.x-1.x-dev	» 5.x-1.x-dev
Priority:	Minor	» Critical

File	Size
gallery_user.txt	590 bytes

A much simpler solution. Don't attempt to create a G2 user for anonymous. This causes the Gallery module to return the standard G2 'path not found' error.

Comment #2

mindless CreditAttribution: mindless commented 19 February 2007 at 15:24

what if a non-guest accesses an invalid path?

Comment #3

kiz_0987 CreditAttribution: kiz_0987 commented 19 April 2007 at 11:32

Priority:	Critical	» Normal
Status:	Needs review	» Needs work

Committed a modified version of this. Still does not work for logged in users, but certainly helps.

Comment #4

profix898 CreditAttribution: profix898 commented 10 May 2007 at 10:59

Version:	5.x-1.x-dev	» 5.x-2.x-dev
Status:	Needs work	» Fixed

As in the 5--2 branch the user sync does no longer happen in gallery_init(), this problem should be fixed. Invalid paths are handled in gallery_handle_request() now, this works for logged in users as well. (An admin will still see ERROR_MISSING_OBJECT, but its catched nicely and remains invisible for 'normal' users.)