Can't retrieve all libraries of a module

library.patch queued for re-testing.

This function is completly rewritten, still an issue?

Can you rewrite the patch matching the current function? Please?

Rob, can you re-roll this patch? Looks pretty much ready to me.

Missing argument 2 for drupal_get_library(), called in modules/simpletest/tests/common.test on line 1382

+++ includes/common.inc	16 Sep 2010 16:31:22 -0000
@@ -3983,19 +3983,17 @@ function drupal_add_library($module, $na
+ *   (optional) The name of a registered library to retrieve. If not provided,
+ *   will retrieve all libraries defined by the module.

"By default, all libraries defined by $module are returned."

+++ includes/common.inc	16 Sep 2010 16:31:22 -0000
@@ -3983,19 +3983,17 @@ function drupal_add_library($module, $na
  * @return
  *   The definition of the requested library, if existent, or FALSE.

@return also needs a slight adjustment.

+++ includes/common.inc	16 Sep 2010 16:31:22 -0000
@@ -3983,19 +3983,17 @@ function drupal_add_library($module, $na
- * @todo The purpose of drupal_get_*() is completely different to other page
- *   requisite API functions; find and use a different name.

Why did you remove this? The comment is still valid, so let's keep it.

+++ modules/simpletest/tests/common.test	16 Sep 2010 16:31:22 -0000
@@ -1276,6 +1276,16 @@ class JavaScriptTestCase extends DrupalW
+   * Tests the retrieval of libraries.
+   */
+  function testGetLibrary() {

Don't we have a test for retrieving libraries already? We can add those 4 lines to the existing. No need to setup an entirely new test environment for that.

Powered by Dreditor.

Also, what happens if you pass a $module that does not implement hook_library()? The test should check that, too.

I think I'm going to need this for Libraries API, so here's a complete patch, incorporating all of the above feedback.

Looks like a nice, small, non-BC breaking change to add in some needed functionality. Appreciate the tests, too.

Committed to HEAD. Thanks!