Closed (fixed)
Project:
CVS integration
Version:
6.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
29 Jun 2006 at 06:07 UTC
Updated:
2 Mar 2008 at 18:51 UTC
Often you'll see committ messages that overflow off to the right, like here:
http://drupal.org/project/cvs/70707
Now, of course you can but line breaks in your commit message to avoid that, and maybe it's by design to enforce nowrap. But I don't see any reason why we don't fix it so it wraps. Just add this to project.css:
.description PRE {
white-space:normal;
}
and voila!
Cool?
Comments
Comment #1
markc commentedWouldn't this be even better ?
Comment #2
DaveNotik commentedThat adds a scrollbar, which is kind of odd -- unless of course you want to preserve the nowrap thing.
My suggestion, however, just causes it to wrap.
Comment #3
dwwall the pages you're talking about are generated by the cvs.module, not project.module. unfortunately, there's no cvs.css file, so the patch doesn't really make sense on its own. however, i don't think it's a good idea to add cvs.module-specific CSS code to project.css. either we should fix this on drupal.org via the bluebeach theme, or we should add a cvs.css file and put this there. for now, i'm in favor of fixing it via a cvs.css, which is why i'm moving this issue to the cvs.module's issue queue... but, we therefore need a new patch for this...
also, not having tested any of this, i'm more in favor of wrapping the text than adding a scrollbar.
thanks,
-derek
Comment #4
anders.fajerson commentedJust noticed that http://drupal.org/cvs adds
<style type="text/css"> pre { white-space: pre-wrap; white-space: -moz-pre-wrap; word-wrap: break-word; }</style>to theWhich is similar to the solution I proposed at http://drupal.org/node/181053:
I don't know enough of project* inner workings to propose where this should be put, hence not a patch.
Comment #5
hunmonk commentedi've committed the css from #4 to cvs.css, patched the file and tested on a local install. it all worked wonderfully, except it doesn't seem to be working on d.o, even after clearing css/browser caches :(
anybody have any suggestions?
Comment #6
jpetso commentedI also ported and committed this fix to Version Control API's Commit Log.
Comment #7
junyor commentedSomeone from the Infrastructure team probably needs to look at this to figure out why the Drupal.org theme is removing these styles.
Perhaps you could move this to fixed (since a fix has been committed) and reopen http://drupal.org/node/197084, moving it to the Infrastructure project?
Comment #8
hunmonk commentedgood suggestion.
Comment #9
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.