error_get_last() in ctools.module [#710490]

Comment	File	Size	Author
#8	ctools-php-version-requirement-warning.patch	1.54 KB	thsutton
#6	ctools-php-version.patch	1.53 KB	thsutton

Comment #1

merlinofchaos CreditAttribution: merlinofchaos commented 10 February 2010 at 18:09

DOH!

That bit needs to check for PHP version then. I totally missed that was a PHP 5.2 function when I wrote that. :/

Log in or register to post comments

Comment #2

mithril293 CreditAttribution: mithril293 commented 10 February 2010 at 19:58

This is completely off topic, but do you get your name from the Chronicles of Amber series by Zelazny?

Log in or register to post comments

Comment #3

merlinofchaos CreditAttribution: merlinofchaos commented 10 February 2010 at 20:13

Yes I did. =)

Log in or register to post comments

Comment #4

mithril293 CreditAttribution: mithril293 commented 11 February 2010 at 13:15

I absolutely loved the series. I've read it several times... and am sad that the author is no longer with us to write more books!

I was wondering, to triage our installation, would there be any harm in commenting out the function call? I have reason to believe that PHP erroring out there is possibly causing other shutdown functions to not be processed. This, in turn, may have something to do with us getting primary key violations on the menu_router table. This is just a hypothesis, but its the best I have to go on at the moment. I just learned about the xdebug module and installed it yesterday. Today I should have a better picture of what is going on.

Log in or register to post comments

Comment #5

merlinofchaos CreditAttribution: merlinofchaos commented 11 February 2010 at 16:21

Absolutely. THis is just an improvement on error reporting. If you comment it out (and possibly a line or two after it) it will simply fail to report errors. I can see where it might obscure the real error that is happening.

Log in or register to post comments

Comment #6

thsutton CreditAttribution: thsutton commented 12 February 2010 at 08:22

Status:

Active

» Needs review

File	Size
ctools-php-version.patch	1.53 KB

I just encountered this in moving code to a production server running PHP 5.1 and hacked up the attached patch before I looked for an issue.

The patch adds a check for the error_get_last() function ctools_requirements() and reports the version requirement if it is missing. It also adds a function_exists() to the if that calls error_get_last.