When activating the "Display facets before a search has been executed." option on a fresh drupal+luceneapi install ("Author" and "Content type" blocks also activated and selected to be displayed in admin/build/block, some content created via devel, nothing else done) I get the following notices, the latter several times:

notice: Undefined variable: type in …/luceneapi/contrib/luceneapi_facet/luceneapi_facet.block.inc on line 202.
notice: Undefined index: count in …/luceneapi/contrib/luceneapi_facet/luceneapi_facet.module on line 928.

Activating "Show counts." at least removes the latter notice(s), but the first one remains.

Also, the facet blocks still get displayed when there is no content yet and therefore nothing but the "Author" and "Content type" headings to display. This shouldn't be the case, imo, but this would be more of a feature request probably.

Comments

cpliakas’s picture

cpliakas commented
Priority: Minor » Normal
Issue tags: +6.x-2.1

Hi drunken monkey.

Thanks for your bug report (and all of your other great and important work with search). Regarding the undefined variables, these should obviously be fixed. I also think that your last observation is indeed a bug report, because the behavior you describe is actually how Search Lucene API works for non-empty searches. If the facet has no values, the heading is NOT displayed. I am bumping up the priority and flagging the fix for the 6.x-2.1 release.

Thanks again,
Chris

cpliakas’s picture

cpliakas commented
Status: Active » Fixed

Fixed in commit #330182.

Status: Fixed » Closed (fixed)
Issue tags: -6.x-2.1

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +6.x-2.1

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.