Comments

EPO’s picture

StatusFileSize
new995 bytes

Same same but different

EPO’s picture

Status: Active » Needs work

Forget to set appropriate status.

EPO’s picture

Remark: I am aware of the problem that there may be no quantity defined. But a coding like this:

$variables['subtotal'] += ec_store_adjust_misc($txn, $item) * (ec_product_has_quantity($item) && isset($item->qty) ? $item->qty : 1)

is awkward and ill. "$item" is an object, and therefore the constructor have to take care of a proper initialization of the object. If for any reason there is a problem it is a problem of the constructor or perhaps with inheritance (objects with and may be without quantity are of different type and must have different constructors).

xen’s picture

Component: ec_charge » ec_store
Status: Needs work » Needs review
StatusFileSize
new1.59 KB

Merged patches and reworked to use ec_product_check_qty.

gordon’s picture

let testing at it

Status: Needs review » Needs work

The last submitted patch, 708824.patch, failed testing.

gordon’s picture

Version: 6.x-4.0-rc15 » 6.x-4.x-dev
Status: Needs work » Needs review
StatusFileSize
new1.54 KB

Rerolled for 6.x-4.x-dev

gordon’s picture

Status: Needs review » Fixed

Thanks @Xen

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.