Active
Project:
XML sitemap
Version:
7.x-2.4
Component:
xmlsitemap_user.module
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
8 Feb 2010 at 16:16 UTC
Updated:
26 Dec 2018 at 12:48 UTC
Jump to comment: Most recent
Comments
Comment #1
dave reidAdding release blocker tag.
Comment #2
Anonymous (not verified) commentedI don't know about 7 but for 6 it is pretty darn ugly. When the 'form' is loaded set a static cache of the account removing the form_build_id from the object, unserialize the object->$data and remove the form_build_id element from the array. On the 'after_update' move the $account variable to another variable in order to do the dance with form_build_id so that you can compare the before image and after image copies to know if you need an update. You have to remove the form_build_id because the values are different in the before and after.
HTH
Comment #3
dave reidComment #4
dave reidI think #786484: Use a 'link update' queue for delayed link changes is what we'll need to fix this... that way we get the fully changed user account variable at the end of the page request or during cron.
Comment #5
dave reidComment #6
Anonymous (not verified) commentedI've added a note to Known Issues that will need removed once this is corrected.
Comment #7
Anonymous (not verified) commentedDave, I've been trying to determine why xmlsitemap_user module isn't saving the changes to include or exclude the user in the sitemap. I see that xmlsitemap_process_form_link_options() is added to the #submit array and it is called, however that function doesn't do the save. Instead it is waiting for xmlsitemap_user_user_update() hook implementation to do the save but the $account variable doesn't contain the changed value and neither does the $edit variable.
Is there a reason not to save the data on submit? What purpose is accomplished in waiting for the hook_*_update() function? I realize if we refactor this piece that we must do so for all entities.
Comment #8
webservant316 commentedstatus update? is the user sub-module still off limits?
Comment #9
Leeteq commentedComment #10
Leeteq commentedThe issue that held up
#786484: Use a 'link update' queue for delayed link changes
was fixed 4 years ago, and one year ago a patch to that one was posted tentatively, which is still awaiting review / feedback.
Comment #11
Leeteq commentedComment #12
webservant316 commentedIs the the user sub-project still unusable? I saw there was a new release, but I didn't think I saw any patched related to this issue? I would like to use the user sub-module if available.
Comment #13
webservant316 commentedstill no patch?
Comment #14
VIPIN M P commentedHi..
Can any one have update the individual user exclude related work with sitemap ?