I've attached a patch that better handles errors when the module can't connect to the Google server. Happens most often with a lack of server config information, but can bring a site down with a WSOD if not handled properly.

Also passes better strings for exceptions, so you don't get duplicate preceding messages, like: "The Google appliance has an error: there is an error in the google appliance: (actual error)".

CommentFileSizeAuthor
#2 better_exception_handling_2.patch4.79 KBsamlerner
better_exception_handling.patch5.27 KBsamlerner

Comments

larskleiner’s picture

larskleiner commented

Thanks for supplying these patches, they look great.

I only had a chance to test this one as we don't run a Google Mini on a https connection to test 691152: Better handling of XML errors when making cURL requests and I'm not sure about the best way to test the date range changes in 691156: Fix for date searching when no keyword is present via the standard google appliance search form.

This patch seems to do the job, I'd like to commit it.

Would it be ok for you to strip out the daterange change to inmeta before I do so? They probably should be reviewed along with the other changes in 691156: Fix for date searching when no keyword is present.

samlerner’s picture

samlerner commented
StatusFileSize
new better_exception_handling_2.patch4.79 KB

Sure, I've attached a modified patch that removes the date stuff. Didn't belong in this patch anyway.

larskleiner’s picture

larskleiner commented

Thanks, I commited your patch.

The last patch didn't seem to work for some reason so I used the first one and stripped out the daterange stuff again.