In the readme it says to move the extracted dataTables-1.5/media in a sites/all/modules/datatables/dataTables/ folder. Should the final path be:

sites/all/modules/datatables/dataTables/dataTables-1.5/media

or

sites/all/modules/datatables/dataTables/media

If the first, what if you install the new 1.6 version of dataTables (or any future version)? Should it then be:

sites/all/modules/datatables/dataTables/dataTables-1.6/media

Comments

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented

ok, I've found the solution myself...

I noticed the relative entry in drupal's status report page and tried different things until I finally got it right. The plugin comes in a .zip file and if you extract it a 'dataTables-[version#]' folder is created that contains the 'media' subfolder. If one extracts this on the module's folder, they'll end up with a 'sites/all/modules/datatables/dataTables-1.5/media' path while the module expects a 'sites/all/modules/datatables/dataTables/media' one. They only need to rename 'dataTables-[version#]' to simply 'dataTables' (delete the '-' and version # from the filename).

So, I think it would be more clear if you updated the information in the readme to state that the final path should be:

sites/all/modules/datatables/dataTables/media

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented
Status: Active » Closed (fixed)
duellj’s picture

duellj CreditAttribution: duellj commented

You're right, klonos, that's a bit confusing. I'll update the README.txt file with clearer directions.

Thanks!

ClearXS’s picture

ClearXS CreditAttribution: ClearXS commented
Title: jQuery datables subfolder path » jQuery datatables subfolder path
Component: Documentation » Miscellaneous
Category: support » feature
Status: Closed (fixed) » Active

I like to reopen the issue, as since then there has been a policy change to have plugins and libraries located in sites/all/libraries and sites/all/plugins, instead of the module directory. As the plugin (or library?) is gigantic and doesn't come with the module, I suppose there is all reason to apply that policy?

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented
Title: jQuery datatables subfolder path » Add Librarie API support (f.k.a. jQuery datatables subfolder path)
Component: Miscellaneous » Code

Actually it is more like a trend then a policy and also it is not a mater of statically changing the path in the module code, but adding support for the Libraries API that will hopefully add a bunch of other goodies regarding libraries management in the future.

I'm +1 for it too.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented
Title: Add Librarie API support (f.k.a. jQuery datatables subfolder path) » Add Libraries API support (f.k.a. jQuery datatables subfolder path)

...missed an 's' there ;)

duellj’s picture

duellj CreditAttribution: duellj commented

@ClearXSClearXS: Has this been a policy change? If so, can you link to the documentation/discussion? I wouldn't be opposed to moving the datatables library to sites/all/library if that's the trend modules are making.

@klonos: good call on the libraries API, I'll definitely add support for that in the 7.dev release, since hook_library is in core now (http://api.drupal.org/api/function/hook_library/7). Do you know if there's a benefit to using libraries API over hook_library in D7? I'll think about using it in D6 as well.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented

Hey Jon, thanx for taking the time to reply and for considering this one (do so for D6 too - pretty please)!

Basically what ClearXS and I are saying is the same thing. Please take a better look at the Libraries API page. It says (among other things):

This module introduces a common repository for libraries in sites/all/libraries resp. sites/<domain>/libraries for contributed modules.

...and goes on about listing the basic benefits of using it. I am pretty confident this will be in D8 core.

As for the benefit of hook_library, I couldn't know. It does seem like a legit question (support request) for the Libraries API issue queue though. Want me to file an issue for that or will you do it since you can ask in more detail (being able to code modules and all).

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented

...sorry about the ninja-edit, but I forgot to close the blockquote tag ;)

duellj’s picture

duellj CreditAttribution: duellj commented
Status: Active » Fixed

Libraries API is now in 7.x: http://drupal.org/commitlog/commit/12588/4ac8063c6d31c64d6a5d9bf380265c8...

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented
Version: 6.x-1.x-dev » 7.x-1.x-dev

Thanx Jon! Well, it's been long since I've moved almost all my sites to D7, so just curious: will this be in for 6.x too?

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

duellj’s picture

duellj CreditAttribution: duellj commented

@klonos: nope, only bug fixes will go into the 6.x branch

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented

Ok. Thanx for taking the time to reply.

Chris Gillis’s picture

Chris Gillis CreditAttribution: Chris Gillis commented
Status: Closed (fixed) » Active

Just one point... the folder in the libraries folder needs to be named "datatables", not "dataTables" (lowercase T).

The readme currently says incorrectly:

you can place the dataTables folder in sites/all/libraries/.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented
Component: Code » Documentation
Category: feature » bug

...temporarily switching component and category till this is sorted out.

eule’s picture

eule CreditAttribution: eule commented

+1 Chris Gillis Comment,

add the right path to site/all/libraries you use in the readme.txt
seems to work with site/all/libraries/datatables

duellj’s picture

duellj CreditAttribution: duellj commented
Status: Active » Fixed

Thanks, updated the readme

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • duellj committed 4275d13 on 7.x-1.x, 7.x-2.x 
    #699538 - adds additional help text for library support