Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.IMPORTANT:
This patch is directly related to and interdependent on a related patch to provision module:
#697954: user 1 name is hardcoded. allow provisioners to specify name for admin user.
You must install both!
In this patch:
- various updates to accomodate per-site administrator username settings on node/add/site form
- constant value for "admin" and and configurable system-wide default variable ( added to node form at admin/content/node-type/site )
- validation using user.module's
user_validate_name
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 699250.patch | 3 KB | mig5 |
| #8 | admin_config.png | 49.7 KB | mig5 |
| #3 | hosting-697954.patch | 7.16 KB | AaronBauman |
| #2 | hosting-697954.patch | 7.58 KB | AaronBauman |
| #1 | hosting-697954.patch | 7.14 KB | AaronBauman |
Comments
Comment #1
AaronBaumanre-patched.
see below.
Comment #2
AaronBaumanfixes issue where pre-existing / legacy sites without an empty value for admin_user could not be edited through node edit form
Comment #3
AaronBaumanremoved some garbage from the previous patch.
sorry for the WOB.
Comment #4
Anonymous (not verified) CreditAttribution: Anonymous commentedSorry for the delay in reviewing your work.
Everything here works as expected, well done.
The patch no longer applies cleanly but that's because of work we've done. But I can clean that up when I commit. See the other ticket for some other comments
Comment #5
Anonymous (not verified) CreditAttribution: Anonymous commentedI committed a simplified version of this along with the other - see http://drupal.org/node/697954#comment-2942812
Thanks again, great work :)
Comment #6
adrian CreditAttribution: adrian commentedThis form is already ridiculously complex to fill in, i believe we shouldn't add more stuff to it willy nilly, or risk sacrificing usability.
For a large majority of our use cases, we dont need to have this name be configurable by the person creating the site, as it is already configurable the moment they log in for the first time, and we then keep this information in our database and have to keep it in synch (or why do we have it otherwise)
Since this has already made it in, i believe that we should keep it , but make the element hidden by default. So the element shouldn't show up unless you specifically make it configurable.
Comment #7
Anonymous (not verified) CreditAttribution: Anonymous commentedOK, I'll work on it today.
We aren't keeping it in sync with what the user potentially changes it to later, so I am not against reverting it.
Comment #8
Anonymous (not verified) CreditAttribution: Anonymous commentedPlease review this patch. Screenshot also attached to show the configurable options.
P.S after reading the IRC backlog, feel free to revert this, I was obviously wrong in assuming it'd be useful (and, I didn't hear any objections for 5 months in this or the other ticket #697954: user 1 name is hardcoded. allow provisioners to specify name for admin user. :) ) it hasn't made it into a release so removing it wouldn't require an additional hook_update to remove the fields etc. So now would be a good time.
Comment #9
Anonymous (not verified) CreditAttribution: Anonymous commentedReverted this feature per discussions...