; For example
libraries[swfupload][download][type] = "get"
libraries[swfupload][download][url] = "http://swfupload.googlecode.com/files/SWFUpload%20v2.2.0.1%20Core.zip"
Getting error:
Could not retrieve package information for /tmp/drush_make_tmp_1264512126/SWFUpload%20v2.2.0.1%20Core.zip
Reason awk '{print $4;}', see line 113 and 132 in drush_make.download.inc
Because unzip -l 'SWFUpload%20v2.2.0.1%20Core.zip' will result in
0 2009-03-27 11:58 SWFUpload v2.2.0.1 Core/
19121 2009-03-30 10:38 SWFUpload v2.2.0.1 Core/Core Changelog.txt
...
and therefore unzip -l 'SWFUpload%20v2.2.0.1%20Core.zip' | awk '{print $4}' will result in
SWFUpload
SWFUpload
SWFUpload
...
i.e. SWFUpload treated as 4th column.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | drush_make_uzip_noawk.patch | 1.13 KB | jmiccolis |
Comments
Comment #1
dmitrig01 commentedGood point. What would the best way to go about fixing this be?
Comment #2
cyberwolf commentedSubscribing.
Comment #3
jmiccolis commentedAttached is a patch that replaces the use of `awk '{print $4;}'` with a more rigorous regular expression so that everything is captured properly. Testing is appreciated.
Comment #4
yhahn commentedCommitted: http://drupal.org/cvs?commit=374494
Comment #6
pbuyle commentedThe fix solved the issue for unpack_zip, but unpack_gz (now unpackGz) has the same flaw preventing Drush Make to handle tgz/gz files with space in their names.
PS: Marked as critical because on Windows, temporary files are stored in "C:\Document and Settings\$USER\drush_make_temp_$random" which prevent Drush Make to do anything.
Comment #7
dmitrig01 commentedis this fixed in the latest beta?
Comment #8
dmitrig01 commented(it isn't)
Comment #9
dmitrig01 commentedw00t