BSOD during instalation

This is my patch

Patch hasn't been properly applied in beta7

The same patch but for beta7

Hm. For me, logic is differnet. Look at if statement and its brackets. Function imagecache_presets should be called only once.

Before patch:

  static $presets;
  if (!isset($presets)) {
    $presets = array();

      // Only expose those presets if no presets in the system right now
    $presets = imagecache_presets();
    if(count($presets) > 0) {
        return array();
    }
  }

  // Only expose those presets if no presets in the system right now
  $presets = imagecache_presets();
  if(count($presets) > 0) {
    return array();
  }

  $presets = array();
  $presets['original'] = array (
    'presetname' => t('Original'),
    'actions' => array (),
  );
  $presets['big'] = array (
    'presetname' => t('Big'),
    'actions' =>
    array (
      0 =>
      array (
        'weight' => '0',
        'module' => 'imagecache',
        'action' => 'imagecache_scale',
        'data' =>
        array (
          'width' => '640',
          'height' => '',
          'upscale' => 0,
        ),
      ),
    ),
  );

  return $presets;

After patch:

  static $presets;
  if (!isset($presets)) {
    $presets = array();
    // Only expose those presets if no presets in the system right now
    $presets = imagecache_presets();
    if(count($presets) > 0) {
      return array();
    }
    $presets['original'] = array (
      'presetname' => t('Original'),
      'actions' => array (),
    );
    $presets['big'] = array (
      'presetname' => t('Big'),
      'actions' =>
      array (
        0 =>
        array (
          'weight' => '0',
          'module' => 'imagecache',
          'action' => 'imagecache_scale',
          'data' =>
          array (
            'width' => '640',
            'height' => '',
            'upscale' => 0,
          ),
        ),
      ),
    );
  }
  return $presets;

I was trying to reproduce the error WSOD after intstallation WYSIWYG Imageupload (my mistake - white screen of death, not blue :) )

Try reproduce this error in 4 steps:

1) Install fresh copy Drupal 6.15.

2) Enable:
Color
Comment
Database Logging
Help
Menu
Taxonomy
Update Status

3) Install
Image API 6.x-1.x-dev
Image API GD2 6.x-1.x-dev
Image Cache 6.x-2.x-dev
Image Cache UI 6.x-2.x-dev
CVS Deploy 6.x-1.x-dev
Transliteration 6.x-2.x-dev
jQuery UI 6.x-1.x-dev
jQuery Update 6.x-2.x-dev
Wysiwyg 6.x-2.x-dev
JQueryUpdate 6.x-1.0

Drupal works well.

4) Now, install WYSIWYG ImageUpload and you will see WSOD.

Problem has gone when I patch the beta7 with #5 but first try to reproduce this error before you make any decision and commit changes to your code.