Problem with translated breadcrumb for forum [#695946]

Problem with translated breadcrumb for forum

I'm using a multilingual forum, and found two problems with i18n taxonomy module related to the breadcrumb

1) When using forum inside a container, when displaying the forum, the breadcrumb doesn't include the container.

example :
With the following forum structure
container : "General"
------- forum "News and announcements"
------------ topic "New release"
------- forum "General discussion"
container : "Support"
------- forum "Module"
......................................

when displaying forum "News and announcements" , breadcrumb is displaying "Home >> Forums", instead of "Home >> Forums >> General"

I fixed this issue with the first patch : inside function i18ntaxonomy_preprocess_forums(), parents are parsed to be included on the breadcrumb.

2) When displaying a forum topic, translated breadcrumb is sometimes displaying wrong information. I can not provide a way to reproduce this problem, It just occurs when function i18ntaxonomy_nodeapi() is called, this seems to be due to a bug inside this function. I fixed this issue with the second patch.

Both patchs are for i18n-6.x-1.2 and i18n-6.x-1.x-dev

Comment	File	Size	Author
#5	i18ntaxonomy.module.patch	1.06 KB	moritzz
#3	i18ntaxonomy.module-1.patch	1.63 KB	pdesarnaud
#2	i18ntaxonomy.module-2.patch	633 bytes	pdesarnaud
#1	i18ntaxonomy.module-1.patch	864 bytes	pdesarnaud

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

pdesarnaud CreditAttribution: pdesarnaud commented 26 January 2010 at 17:01

File	Size
i18ntaxonomy.module-1.patch	864 bytes

First patch

Comment #2

pdesarnaud CreditAttribution: pdesarnaud commented 26 January 2010 at 17:02

File	Size
i18ntaxonomy.module-2.patch	633 bytes

2nd patch

Comment #3

pdesarnaud CreditAttribution: pdesarnaud commented 27 January 2010 at 00:55

Status:

Active

» Needs review

File	Size
i18ntaxonomy.module-1.patch	1.63 KB

New patch to fix new issues.

1) Page title doesn't reflect the displayed forum ( when displaying a forum, the page title is always the same : it is retrieved from the vocabulary table using variable 'forum_nav_vocabulary' as id )

2) When displaying a top level forum or container, the breadcrumb is always including the name of the displayed forum/container.

this patch replace the previous i18ntaxonomy.module-1.patch

Comment #4

jpmckinney CreditAttribution: jpmckinney commented 9 August 2010 at 20:08

Version:

6.x-1.2

» 6.x-1.x-dev

-              $breadcrumb[] = l(tt("taxonomy:term:$term->tid:name", $p->name), 'forum/'. $p->tid);
+              $breadcrumb[] = l(tt("taxonomy:term:$p->tid:name", $p->name), 'forum/'. $p->tid);

I came across this typo today. At the very least, that change should be committed.