theme('username') is a nicer way to get an automatic link to a user profile (which isn't rendered as a link if you don't have permissions to view profiles), etc. there are a fair number of places in the code that manually call l(). we should change them.

CommentFileSizeAuthor
#1 signup_theme_username.patch.txt1.16 KBdww

Comments

dww’s picture

dww
we/he/they
commented
Assigned: Unassigned » dww
Category: task » bug
Status: Active » Needs review
StatusFileSize
new signup_theme_username.patch.txt1.16 KB

attached patch applies cleanly for HEAD and DRUPAL-5, with offsets for DRUPAL-4-7. sadly, this function was only added in 4.7.x, so there's no easy solution for this in 4.6.x. oh well. ;)

dww’s picture

dww
we/he/they
commented

http://api.drupal.org/api/4.6/function/format_name handles this same work for 4.6.x, in case someone is inspired for a backport. ;)

add1sun’s picture

add1sun commented
Status: Needs review » Reviewed & tested by the community

Yup, applies cleanly and works a treat. Tested on 4.7.x and 5.1. thx

Btw, what is this strange thing you call 4.6.x? Is that from an ancient history lesson? ;)

dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Fixed

HEAD, DRUPAL-5, and DRUPAL-4-7.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)