I am in the process of upgrading an application from Drupal 5 to Drupal 6. Both versions use Aberdeen liquid. However the sub-tabs don't look the same. In fact the D6 sub-tabs aren't styled at all. See attached.

CommentFileSizeAuthor
aberdeen_d6.jpg16.17 KBjohnhanley
aberdeen_d5.jpg16.18 KBjohnhanley

Comments

ishmael-sanchez’s picture

ishmael-sanchez commented
Assigned: Unassigned » ishmael-sanchez

Ok I think that got in there because of #262787: Remove bullets from admin links . I'll check out the styling and update this issue.

johnhanley’s picture

johnhanley commented

Well presumably something got taken out of the D6 version because the sub-tabs in the D5 version are correct. (Compare above attachments.)

Thanks for the great theme!

johnhanley’s picture

johnhanley commented
Assigned: ishmael-sanchez » johnhanley
Status: Active » Needs review

I finally found time to properly debug this issue.

It turns out the culprit is line 53 in aberdeen/page.tpl.php, which is missing a ul tags with class "tabs secondary" around the output of $tabs2.

Before:

<?php if (isset($tabs2)): print $tabs2; endif; ?>

After:

<?php if ($tabs2): print '<ul class="tabs secondary">'. $tabs2 .'</ul>'; endif; ?>

With this in place the secondary tabs in version D6 are themed just like version D5.

Note that in this case isset() should not be used because $tabs2 is always defined and will output empty ul tags (adding extra space between the primary tabs and content) even when empty.

ishmael-sanchez’s picture

ishmael-sanchez commented
Status: Needs review » Active

Hi Bacteria Man,

Thanks for this and sorry about the delay.

ishmael-sanchez’s picture

ishmael-sanchez commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.