i know we just added this, and i said it was a good idea. ;) however, upon futher consideration, the name seems a little confusing. looking at it on the access page, it suggests the ability to, for example, cancel your own signup to something. 'admin own signups' seems to me like administering your own signups. ;) but that's not what it does. it lets you administer *other people's* signups, just on nodes that you own. it's really something like "admin signups for your own nodes", but that's too wordy. there's no help description available, so it has to be a self-documenting name.

also, for consistency, it should probably be "administer" (all the other permissions, esp. in core, use full words).

any bright ideas?

thanks,
-derek

CommentFileSizeAuthor
#5 signup_permission_rename_47x.patch.txt16.52 KBdww
#4 signup_permission_rename_5x.patch.txt16.18 KBdww

Comments

leoklein’s picture

leoklein commented

Do you really think this is necessary? When I saw the words, 'admin own signups', I started dancing around and singing hallaluha.

I got what it did. Also, it kind of fits in with other similar access permissions as in "edit own page", "edit own blog", etc.

P.S. This is really turning out to be an excellence module!

dww’s picture

dww
we/he/they
commented

yeah, i thought it was necessary, that's why i submitted this. ;) it's not critical, but since the feature just went in, now's the time to change it before folks get used to the other name...

and, my point it that it's *not* like "edit own page". this perm doesn't give you powers to administer your own signups, it gives you power to administer *other* people's signups (and view their personal info) on your own nodes. it's very different.

but yeah, signup is getting quite cool, and will keep getting better. ;)
thanks,
-derek

dww’s picture

dww
we/he/they
commented
Title: rename 'admin own signups' » rename permissions
Assigned: Unassigned » dww
Priority: Normal » Critical

it's not just "admin own signups" that's a mess. after extensive discussion w/ webchick and add1sun in IRC, we came up with the following proposal:

'allow signups' > 'sign up for content'
'admin signups' > 'administer all signups'
'admin own signups' > 'administer signups for own content'

plus, the 2 new permissions:
'view all signups' http://drupal.org/node/69367
'view signups for own content' http://drupal.org/node/126632

this will require quite the signup_update_N() in addition to a fairly extensive patch to the code and docs. but, it's really worth cleaning up. bumping this to critical, since i'd like to deal with all of this before the 5.x-1.0 release.

dww’s picture

dww
we/he/they
commented
Status: Active » Needs review
StatusFileSize
new signup_permission_rename_5x.patch.txt16.18 KB

also includes the work from http://drupal.org/node/69367, since it turns out it's easier to just handle both things in the same DB update. still trying to decide how much of this, if any, to backport to 4.7.x...

dww’s picture

dww
we/he/they
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new signup_permission_rename_47x.patch.txt16.52 KB

here's a 4.7.x backport. i'm going to commit this now, and i'm going to add this to 4.7.x, too. so, i'm sticking with signup_update_4(), since it'll be shared for 4.7.x and 5.x...

dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Fixed

ommitted to HEAD, DRUPAL-5 and DRUPAL-4-7.

csc4’s picture

csc4 commented

Can't find the download for 4.7? Should it be appearing in the latest version or do I need a dev version (which doesn't seem to be listed on the project page?)

dww’s picture

dww
we/he/they
commented

i have the development releases intentionally not visible on the project page, since it's *much* better for people to use the official releases. that's by design. i haven't made a new official release for 4.7.x yet that includes this fix, since it still needs a little more testing before i'm ready to ship it, and there are a few other bugs i might fix before the next release.

that said, you can always find all the releases for a module on the "View all releases" link from a project node. for example:

http://drupal.org/node/29351/release

however, don't use the current dev snapshot there, since it's broken (until the packaging scripts run again). see http://drupal.org/node/131115 about that. see, good reason i didn't make a new release, since it wasn't ready for production use, yet. ;)

csc4’s picture

csc4 commented

Ah, ok, thanks!

I take it then that I shouldn't try to use this functionality until you issue it as the proper release?

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)