There is a typo in the blog.module: a href='@blog''

Files: 
CommentFileSizeAuthor
#10 apostrophe-691456-3.patch1.54 KBBoobaa
Passed on all environments. View
#8 apostrophe-691456-2.patch32.3 KBBoobaa
Passed on all environments. View
#5 apostrophe-691456-1.patch32.3 KBBoobaa
Invalid PHP syntax in blog.module. View

Comments

Boobaa’s picture

Title: Extra apostrophe » Wrong apostrophes in links (eg. <a href='foo'>)
Component: blog.module » markup
Category: task » bug

There are quite a few other places in core with <a href='foo'> - will try to patch'em all soonish.

zserno’s picture

Issue tags: +Novice

This is an excellent opportunity for new contributors, so tagging it with Novice.

qasimzee’s picture

I am fresh to drupal open source. Can we attach our patch on the same page with comment ?

I have read some pages but unable to find this information.

Boobaa’s picture

Patch is on the way, i'm already working on it; expect results in ~10 mins.

Boobaa’s picture

Status: Active » Needs review
FileSize
32.3 KB
Invalid PHP syntax in blog.module. View

Sorry for the delay, CVS is like a snail here.

I haven't touched jquery.js nor comment.test as I don't know whether it's a bug there as well.

Heine’s picture

Status: Needs review » Needs work

Did you try the patch?

This simply won't parse:

t('The Blog module allows registered users to maintain an online journal, or blog. Blogs are made up of individual blog entries. By default, the blog entries are displayed by creation time in descending order, with comments enabled, and are promoted to the site's front page. For more information, see the online handbook entry for Blog module.'

As single quotes are perfectly valid as attribute value delimiters, why not just use '@blog' ? If you do want to use double quotes, either escape (\") them, or use a single quote delimited string and escape the lone single quote (\') after site

zserno’s picture

Status: Needs work » Active

@qasimzee: Welcome to Drupal :)
So when someone creates a patch then writes a comment with the attached .patch file. (Below the comment's textbox you can see a 'File attachments' form element.)
Also it's a common practice to change the issue status to CNR (code needs review) whenever a new patch is attached so the test bot will automatically run its tests to find out if that patch breaks something in Drupal's core.

Boobaa’s picture

Status: Active » Needs review
FileSize
32.3 KB
Passed on all environments. View

@Heine in #6: Thanks for pointing me at that tyop; look's like I should set up my own testbot environment. :S

Corrected (and tested) patch is attached.

zserno’s picture

@Boobaa: I really don't understand why you're changing all single quotes to double ones. As Heine already mentioned above, single-quoted attribute values are perfectly ok. Source: http://dev.w3.org/html5/html-author/.
So I'd suggest focusing only on the original typo.

Boobaa’s picture

FileSize
1.54 KB
Passed on all environments. View

Attached is the patch which solves OP, without disturbing the force more than needed. Sorry for the already-done disturbances.

Zoltán Balogh’s picture

Title: Wrong apostrophes in links (eg. <a href='foo'>) » Extra apostrophe in blog.module
Status: Needs review » Reviewed & tested by the community

#10 is OK

qasimzee’s picture

@zserno: Thanks a lot for your guidance

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.