Flag unnecessarily calls _comment_load() when doing access checks. This causes one additional query for each comment in a page, because _comment_load() doesn't do any caching.

CommentFileSizeAuthor
#1 690248-comment-cache.patch895 bytesdamien tournoud

Comments

damien tournoud’s picture

damien tournoud commented
Status: Active » Needs review
StatusFileSize
new 690248-comment-cache.patch895 bytes

Time to use ->remember_content().

quicksketch’s picture

quicksketch
he/him
commented

Thanks Damien! Not sure why we weren't doing that already. I'll commit this next time I'm working on Flag.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed

Finally committed this. Thanks again.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.