Hi,

I porpose to extend the rules action to add some userpoints to an account by some more attributes:
1. 'operation'
2. 'entity_type'
3. 'tid'

This enables to assign the points to a specific category or add some explaining operation to transaction.

As a proposal I added the necessary function revisions.

CommentFileSizeAuthor
#1 userpoints_rules.rules_.inc_.02222010.diff2.44 KB1sp
proposal.txt2.08 KBTS79

Comments

1sp’s picture

1sp commented
StatusFileSize
new userpoints_rules.rules_.inc_.02222010.diff2.44 KB

Hi ,

I needed an extended "Grant points to the user" action, So I patched the userpoints_rules.rules.inc . I am attaching the patch to be reviewed by community. Using this patch you can control almost every attribute of userpoints transaction from the action form. Following new attributes are now supported:

  • Userpoints category support (A long standing request)
  • entity type support
  • entity id support (with php evaluation support)

The patch was created against latest dev version (22nd feb, 2010)

Cheers,
Sudhir

YK85’s picture

YK85 commented

Subscribing, awesome work!
Can we replace the current userpoints_rules.rules.inc file with this one?
Just wondering as the above isn't a patch file against the current that exists.
Thanks!

thekayra’s picture

thekayra commented

Awesome. Subscribing. Will give it a try in the day.

1sp’s picture

1sp commented

this patch is against today's dev release

kbahey’s picture

kbahey commented
Status: Needs review » Fixed

Thank you so much for this patch.

I committed it.

It will be part of the tarball in about 12 hours.

YK85’s picture

YK85 commented

Thanks for the great work!

BenK’s picture

BenK commented

Awesome! Looking forward to trying this out....

Anonymous’s picture

Anonymous (not verified) commented

Holy crap I was just about to sit down and figure this one out and you did the work for me! Sweet!

1sp’s picture

1sp commented

Thanks!! You all motivated me.

Cheers,
Sudhir

gaurav_m’s picture

gaurav_m commented

good job!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

__mark’s picture

__mark commented
Category: feature » bug
Priority: Normal » Major

Did anyone notice that the Entity ID field does not understand $node->nid objects (or, as the field description puts it: $node->id)? It is accepting integers, so it's not completely broken.

Does anyone have an idea on where to start on getting this patch to work? Would it be where the form is created: userpoints_action_grant_points_form()?

__mark’s picture

__mark commented
Priority: Major » Normal

however, tokens work. problem solved.