Signup status mailer works perfectly if the status is set initially using the signup node form. It works perfectly if the status is changed using Views Bulk Operations. But if the status is changed using the signup edit form, signup status mailer doesn't send anything-- there's no action listed in the access log.

Any help would be appreciated!

I'm setting this to critical because it seems like a pretty key function to be broken.

CommentFileSizeAuthor
#3 signup_status-mail_upon_status_update.patch1.09 KBteliseo

Comments

ccrackerjack’s picture

ccrackerjack commented

I have tested and having the same bug/problem.

subscribing

ln282’s picture

ln282 commented

I've found what's causing the problem, but haven't nailed down the right solution yet. The issue is that the if statement in signup_status_alter_signup_edit_form_submit that is supposed to test whether or not the status has been changed isn't working correctly, and _signup_status_change('update', $signup) is never called, even if the status has been changed.

Because I'd rather send too many emails than none at all, I've commented out the if-statement so that _signup_status_change('update', $signup) gets called every time.

I'm working on a better solution, and I'll post when I figure it out.

teliseo’s picture

teliseo commented
Priority: Critical » Normal
Status: Active » Needs review
StatusFileSize
new signup_status-mail_upon_status_update.patch1.09 KB

@ln282: The problem is that signup_status_signup_data_alter() was clobbering the old value before signup_status_alter_signup_edit_form_submit() is called. The attached patch does the right thing and fixes this bug, regardless of the call order.

jlbellido’s picture

jlbellido
Primary language Spanish
commented
Status: Needs review » Reviewed & tested by the community

#3 it works! thanks @teliseo :D

xaa’s picture

xaa commented

many thanks ! #3 working