I just tried implementing hook_receipt_filter, and discovered that it's rather useless as it simply get 2 NULL arguments.

Attached patch makes ec_receipt_checkout_init pass the transaction object, and fixes _ec_receipt_filter to pass it to the hook implementation, as it seems to be intended.

CommentFileSizeAuthor
#5 0001-689068-Fix-up-issues-related-to-the-receipt-filter.patch1.73 KBgordon
receipt_filter.patch2.37 KBxen

Comments

gordon’s picture

gordon commented

submit for testing

Status: Needs review » Needs work

The last submitted patch, receipt_filter.patch, failed testing.

gordon’s picture

gordon commented
Version: 6.x-4.0-rc15 » 6.x-4.x-dev
Status: Needs work » Needs review

move to the dev branch for testing.

gordon’s picture

gordon commented

receipt_filter.patch queued for re-testing.

gordon’s picture

gordon commented
StatusFileSize
new 0001-689068-Fix-up-issues-related-to-the-receipt-filter.patch1.73 KB

Update to 6.x-4.x-dev

gordon’s picture

gordon commented
Status: Needs review » Fixed

Thanks, I have committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.