Here's what I'm experiencing.

I have a Drupal 6.14 site that's a few months old, and I want to upgrade it. But first, I wanted to try running this module to see if there are any core/contrib module hacks.

Hacked! correctly picks up the core modifications, but it is flagging false-positive on every. single. contributed module:

Sad panda.

However, in a few spot-checks, when you run diff -rup on the command line against the same version of the module, there are no differences reported.

After an hour or so of thinking I was losing my mind, I finally tried downloading the current release of the Ad module (2.2), and comparing it against the one in this site (2.1). And bingo. Modifications galore.

So I'm not sure where this logic error in the code this is being introduced, but it should be comparing old, out-of-date modules against their same old, out-of-date equivalent. :)

CommentFileSizeAuthor
#4 hacked-688442.patch1.88 KBsteven jones

Comments

webchick’s picture

Category: bug » support
Priority: Critical » Normal

Hm. Except that's obviously not what's going on with ACL module. Sigh.

steven jones’s picture

Hi webchick, thanks for the bug report.

Can I confirm that you're seeing this issue on osx?

Do you have the diff module installed? If so, hacked should allow you to diff the changed files. This might give some insight to what it thinks has changed.

steven jones’s picture

Ah, Hacked! is trying to download those modules using CVS, not just downloading them.

steven jones’s picture

Status: Active » Reviewed & tested by the community
StatusFileSize
new1.88 KB

Here's a patch.

steven jones’s picture

Status: Reviewed & tested by the community » Fixed

Committed. If you want to get the fix, you'll need the latest development version, clear ALL your caches, and remove the 'hacked-cache' folder from your tmp folder too.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.