The feature added in via #604952: Links need an access check increases the number of queries a lot. There are already a lot of queries, albeit quick short ones that should not effect performance on a properly tuned database server.

This also gets into the scope of footermap. Originally the goal was to simply to have menu items show up in the footer. This was easy in 4.6 and 4.7. With the addition of views and the newer menu implementations in 5.x and 6.x things had to change.

I'm probably going to rollback the changes in #604952: Links need an access check and set that to by design. I'll think about a rewrite in a 6.x-2 and a 7.x-2 branch.

Comments

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Version: 6.x-1.6-beta2 » 6.x-1.x-dev
Status: Active » Fixed

I've reverted the role options that I put in 1.6-beta2. It wasn't really smart. Instead, if necessary, it'll do some access checks based on the cached menu to hide menu items that someone doesn't have access to. This should save the performance there.

Again, in legacy mode, this doesn't make sense as the scope of the module was to have a consistent footer map. However using the block mode it's possible to cache by role, and this will solve that feature request. In the Drupal 7 version legacy mode is deprecated so I've made that switch.

In regards to query performance. The queries shouldn't have any performance limitations. They're fast queries. It's more of an issue with the database server if it can't handle fast queries. Again, this shouldn't be an issue if caching is used.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.