gthing [gthing]

See Apply for contributions CVS access before to apply for a CVS account.

After reviewing the CVS application procedures as well as your theme here's a few things which might help get this through next time.

• Include a screenshot or a link to a site which currently runs the theme. Under the theme contributions section of the CVS application requirements this requirement is outlines.
• Please refer to both the PHP and CSS coding standards. I didn't do a comprehensive review in this respect, but at the very least you are using tabs rather than spaces for indentation.
• Be more consistent with your region names in the .info file. The drupal standard is to capitalize the first word in titles or labels.

That's all I saw. Kiam, if you saw other things please speak up about the specifics. Unfortunately, according to the CVS application guidelines you'll need to submit a new application once you've addressed the code changes and can include a screenshot or link to the theme in action. Good luck gthing.

@beeradb: The reason I marked the report as won't fix is that it was not reported the link to a screenshot, or to a demo site that would mean the applicant didn't carefully read the requirements for a CVS application (which seems commonly done, lately).

@kiamlaluno: understandable, I missed it the first couple reads as well, but it was actually there. Just hidden because the site didn't autolink :)

from page.tpl.php:

<!--[if IE]>
<script src="http://html5shiv.googlecode.com/svn/trunk/html5.js"></script><![endif]-->
<!--[if lte IE 7]>
<script src="js/IE8.js" type="text/javascript"></script><![endif]-->
<!--[if lt IE 7]>

<link rel="stylesheet" type="text/css" media="all" href="css/ie6.css"/><![endif]-->

  <script type="text/javascript" src="wmd.js">
  </script>

None of the referenced stylesheets/JS files are included. I'm assuming these are all for HTML5 compatibility in IE? You should include all of these files, except for the 'html5.js', in the theme. It would also be nice to see them added with drupal_add_js and drupal_add_css where appropriate, so end users can take advantage of CSS/JS aggregation and compression.

If you can fix these issues I'd be willing to mark this RTBC.

This looks good to me. Thanks for the contribution gthing.