anonymous signup support

Against which version of signup was this patch created? I'm getting quite a few hunks FAILED.

Patching against version 4.7 that is:)

Hm. Applies fine here. Not had a chance to test it very much yet though.

I'm using // $Id: signup.module,v 1.45.2.13 2006/06/10 03:01:30 dww Exp $ .. make sure you have the most up-to-date version of 4.7 signup module.

along with all the stuff i've mentioned privately, a few more:

1. this:
   

   $username = l($signed_up_user->name, "user/$signed_up_user->uid");
   

   should be:

   $username = theme('username', $signed_up_user);
   

   so long as $signed_up_user has both a 'name' and 'uid' field, it works great. this takes care of not presenting the link to users that don't have permission to view user profiles, and makes it easier to theme differently, etc.

2. on the node/X/signups tab, i'm not sure the '(Anonymous)' next to each email address is all that helpful. it's not anonymous, we see their email right there. ;) plus, it's clear that we're looking at an email address, not a registered username. it also includes a hard-coded <br/>, which the themers don't like. i'd just take all that out, and leave the email address. maybe that email should be a mailto URL?
3. signup_update_3() fails on pgsql:
   

   warning: pg_query(): Query failed: ERROR: syntax error at end of input at character 52 in /Users/wright/drupal/cvs/4.7/core-4.7.x/includes/database.pgsql.inc on line 84.
   user warning: query: ALTER TABLE signup_log ALTER anon_mail SET default in /Users/wright/drupal/cvs/4.7/core-4.7.x/includes/database.pgsql.inc on line 103.
   warning: pg_query(): Query failed: ERROR: syntax error at end of input at character 35 in /Users/wright/drupal/cvs/4.7/core-4.7.x/includes/database.pgsql.inc on line 84.
   user warning: query: UPDATE signup_log SET anon_mail = in /Users/wright/drupal/cvs/4.7/core-4.7.x/includes/database.pgsql.inc on line 103.
   
   ALTER TABLE {signup_log} ADD anon_mail text
   Failed: ALTER TABLE {signup_log} ALTER anon_mail SET default
   Failed: UPDATE {signup_log} SET anon_mail =
   ALTER TABLE {signup_log} ALTER anon_mail SET NOT NULL
   DROP INDEX {signup_log}_uid_nid_idx;
   CREATE INDEX {signup_log}_uid_idx ON {signup_log}(uid);
   CREATE INDEX {signup_log}_nid_idx ON {signup_log}(nid);
   

the stuff i mentioned in our latest YIM session should be fixed, too:

1. renaming "signup_form_view" (i think i'd just take out the "_view" part, which seems out of place).
2. removing the <p> from inside t()
3. using $needs_signup_form = db_num_rows($result) == 0; for clarity
4. clarifying that stray break;

i think that's it. ;)

i'll do a quick review of your (hopefully final) next patch whenever you post it. looking forward to marking it RTBC...

thanks for the good work, hunmonk!
-derek

i learned the secret for db_add_column() working with NOT NULL varchar fields:

instead of this:

array('not null' => TRUE, 'default' => ''));

you want this:

array('not null' => TRUE, 'default' => "''"));

(note the extra quote marks for the value used in 'default'). then it all works like a charm.

enjoy,
-derek

upon further consideration, my point #1 about

$username = theme('username', $signed_up_user);

shouldn't be fixed in this patch.

a) it was like that before
b) there are probably a bunch of other places in the code that don't use theme('username') like this.
c) i like to keep individual commits as small as possible.

so, the anon patch should stick to anon (even though it had to move around one of these user links), and we can clean up all the theme('username') stuff in a separate issue.

looks great. nice work. thanks for putting up with me. ;)

Is there still no built-in anonymous signin possible? Do I still need this patch?