The check in uc_product_keys_list_sequences_form_submit that works out if a sequence has been altered does not work if a fields #default_value is NULL.

So if a non-mandatory field is left blank when the sequence is initially created it then fails to update later due to a check for isset($item['#default_value']).

This patch addresses this problem.

CommentFileSizeAuthor
uc_product_keys_dirty.patch708 bytesagileware

Comments

freixas’s picture

freixas commented
Assigned: Unassigned » freixas

Thanks. I'll add the patch as soon as I get a moment to work on this project.

freixas’s picture

freixas commented
Status: Needs review » Fixed

Sounds reasonable. Thanks for catching this!

I applied your patch. The fix will appear in the next dev version dated 1/25/10 or later.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.