l10n_project download checking is bugos

l10n_project does check whether drupal_http_request() return a value, but that object can be just a sign of error, which is not taken into account. So we should add return status code checking as well before we go ahead and create the file. Also, add the HTTP error to the watchdog log, so we can monitor why such issues are happening. This will hopefully catch issues before we reach tar to untgz the file. Currently we have these kind of sequences in the watchdog log which are indicative of faulty targz files downloaded.

Monday, January 11, 2010 - 04:50
tar -xvvzf '...../feedfield-5.x-1.1.tar.gz' -C '...../tmp/l10n_project_KtrRDq_dir' failed with status 2
gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error exit delayed from previous errors

Monday, January 11, 2010 - 05:30
File sites/default/files/tmp/feedfield-5.x-1.1.tar.gz already exists.

Monday, January 11, 2010 - 05:30
Contents of sites/default/files/tmp/feedfield-6.x-1.1.tar.gz have been scanned.

Monday, January 11, 2010 - 05:50
Contents of sites/default/files/tmp/feedfield-5.x-1.1.tar.gz have been scanned.