Add the ability to change the title of the link used.
| Comment | File | Size | Author |
|---|---|---|---|
| #21 | follow_link_titles-673798-21.patch | 1.63 KB | guillaumev |
| #11 | follow6title.patch | 3.46 KB | robloach |
| #10 | follow5title.patch | 4.68 KB | robloach |
| #7 | follow5title.patch | 4.5 KB | robloach |
| #3 | Screenshot-Site-follow-links-_-localhost---Mozilla-Firefox.jpg | 175.78 KB | q0rban |
Comments
Comment #1
pwolanin commentedThis looks a reasonable addition that allows better customization.
In the last screenschot - I think I'd want the default text filled in rather than letting a blank be a fall-back to the default text. I guess that means you will potentially end up storing the default title in the DB?
An alternative would be to have an additioanl column listing the default values so the user can see what's going to be used if they leave it blank.
Comment #2
robloachThat's a good point. We don't want to store defaults in the database, but we do want the connection to be clear that it's an overriden name. After talking with you online, I think changing the column title to "Customized Name" would make that connection. Here's a reroll.
Comment #3
q0rban commentedHmm.. I'm torn about this. I want the end user UI to be dead simple. What about something like the attached? Ignore the icons and placement and all that.. this is just a mockup.
Basically every title would have an edit button next to it, and clicking that button hides the default title and shows the field for adding a custom title. Clicking the delete button would clear that field, hide it and show the default title.
Comment #4
robloachI like that user interface a lot. Although the end user UI has to be dead simple, so does the development side. Remember that it has to also work without JavaScript or CSS enabled. Progress enhancement and feature scope are the key things here ;-) .
Comment #5
q0rban commented> Although the end user UI has to be dead simple, so does the development side.
Agreed.
> Remember that it has to also work without JavaScript or CSS enabled.
If the textfield shows up underneath the default title with CSS/JS Disabled, I'm fine with that. It might be good to have a label for the textfield though with CSS/JS disabled, as it wouldn't be completely clear what that textfield would be for anymore.
If if you don't like that idea, the other option (although a little more complex and possibly error prone accross different browsers) is to leave it exactly as you have it in your screenshot and pull the table cell contents out of that column, merge with Column A, and remove Column C altogether ala my screenshot, all in the JS/CSS.
Comment #6
robloachI think the best solution for now is to just get that title column in, and then make a follow up issue for the improved user interface you suggested.
Comment #7
robloachHere it is for the Drupal 5 branch. #2 is the patch for the Drupal 7 branch.
Comment #8
q0rban commentedTested the update, the permissions and the form. Only tested #2. Looks good to me.
Comment #9
q0rban commentedCommitted D7: http://drupal.org/cvs?commit=310250
Comment #10
robloachThanks for hitting that up.... Correction on the DRUPAL-5 patch....
Comment #11
robloachHere's DRUPAL-6--1.
Comment #12
q0rban commentedHmm, I think I'd rather wait till we backport the other changes from HEAD back to D6 before this.
Comment #13
robloachHit up DRUPAL-5: http://drupal.org/cvs?commit=310260 . The Drupal 6 branch is the only one that's missing, and then we can hit up #674960: Sexy title user interface. The DRUPAL-6--1 patch is at http://drupal.org/node/673798#comment-2438138 .
Comment #14
q0rban commentedThanks! Committed: http://drupal.org/cvs?commit=366660
Comment #15
q0rban commentedDang it.
Comment #16
robloachWas this the only change missing in D6?!
Comment #17
q0rban commented> Was this the only change missing in D6?!
heh, no. :)
http://drupalcode.org/viewvc/drupal/contributions/modules/follow/follow....
http://drupalcode.org/viewvc/drupal/contributions/modules/follow/follow....
Comment #19
webankit commentedAbility to hide the title...
Comment #20
webankit commentedComment #21
guillaumev commentedAttached is a patch which will allow you to hide the title, by entering in the customized name...
Comment #22
guillaumev commentedI just found out by reading the README file that it can also be hidden in the CSS by adding:
Comment #23
Tezza commentedThe result I get after applying the patch in #21 is a title that reads 'Follow [site name] on [customised name]'. I was expecting no title. What would be nice is 'Follow [customised name] on Twitter | FB' etc
Comment #24
robloachThanks! Committed to both Drupal 6 and 7. Also took note of the problem Tezza ran into too.