field.api.php is missing an ingroup hooks -- hooks such as http://api.drupal.org/api/function/hook_field_attach_form/7 are not showing here http://api.drupal.org/api/group/hooks/7

CommentFileSizeAuthor
#22 fieldapi-group-673224-22.patch1.76 KBdrupal_was_my_past
#17 fieldapi-group-673224-17.patch1.78 KBdrupal_was_my_past
#9 673224_V2.patch1.69 KBaspilicious
#1 673224.patch1.69 KBjhodgdon

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
StatusFileSize
new 673224.patch1.69 KB

Here's a patch. That file was referencing a group that didn't even exist at the top, and it also had some non-standard doc lines.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Active » Needs review
joachim’s picture

joachim commented

Based on just a read, looks good :)

> - * Field Storage API

These bits are non-standard, but they do seem to be conveying information. Do we definitely want to lose that?

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

The group start/stop lines are already there. The lines of ************* are redundant. I don't think there's a single other file in Drupal core that has them.

smyleeface’s picture

smyleeface commented

#1: 673224.patch queued for re-testing.

smyleeface’s picture

smyleeface commented

Sent for re-test because it didn't apply.

aspilicious’s picture

aspilicious commented

strange, it's green and I can't apply o_O

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work

It doesn't apply for me either. Needs reroll.

aspilicious’s picture

aspilicious commented
Status: Needs work » Needs review
StatusFileSize
new 673224_V2.patch1.69 KB

quick reroll, sleepy so it's possible I made a mistake

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

#9: 673224_V2.patch queued for re-testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

#9: 673224_V2.patch queued for re-testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

#9: 673224_V2.patch queued for re-testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 7.x-dev » 8.x-dev

8.x now...

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

#9: 673224_V2.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 673224_V2.patch, failed testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Guess this needs a re-roll and then a review...

drupal_was_my_past’s picture

drupal_was_my_past commented
Assigned: Unassigned » drupal_was_my_past
Status: Needs work » Needs review
StatusFileSize
new fieldapi-group-673224-17.patch1.78 KB

Re-roll patch from #9.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Let's get this in. Thanks rocket_nova!

dries’s picture

dries commented

#17: fieldapi-group-673224-17.patch queued for re-testing.

dries’s picture

dries commented

Asking for a re-test as the patch does not appear to apply anymore.

catch’s picture

catch
he/him
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)
Issue tags: +Needs backport to D7

Applied fine to me and looks like a good change.

While we're not backporting the big API docs clean-up patches, this looks like a straight bug to me, so moving back to 7.x for backport.

drupal_was_my_past’s picture

drupal_was_my_past commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new fieldapi-group-673224-22.patch1.76 KB

7.x ported patch attached for review.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

This looks fine.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Oh, awesome. This looks very helpful.

Committed and pushed to 7.x. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Needs backport to D7

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Needs backport to D7

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.