Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Mostly wrapping stuff to 80 columns, but also some technical and grammatical tweaks.
Comment | File | Size | Author |
---|---|---|---|
#3 | database-comments-cleanup-2-d7.patch | 39.14 KB | Garrett Albright |
database-comments-cleanup-d7.patch | 39.03 KB | Garrett Albright | |
Comments
Comment #1
Garrett Albright CreditAttribution: Garrett Albright commented+tag
Comment #2
Crell CreditAttribution: Crell commentedThe @return statement for the docblock of DatabaseConnection::query() changes "insert id" to "insert IT". I suspect that is an error. :-)
The docblock for NoActiveTransactionException is wrong, because it's now multi-line for the first line. Class docblocks follow the same rules as function docblocks in that regard.
Same problem for db_query_range() and db_query_temporary(). The first line should not be multiline, even if that means it runs past 80 chars (IMO). And for DatabaseStatement::fetchAllAssoc(). I think that happens a few other times in here, too.
Thanks, Garrett!
Comment #3
Garrett Albright CreditAttribution: Garrett Albright commentedOkay, un-multilined the first lines. I remembered hearing about that when I first started changing things, but wasn't sure if I was remembering things correctly.
Comment #4
Garrett Albright CreditAttribution: Garrett Albright commentedComment #5
boombatower CreditAttribution: boombatower commentedMuch appreciated, looks good.
Comment #6
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.