1) Maybe this sounds weird but i can't control my scrollbar (cant drag it down, its stuck on top) with the overlay on (google chrome), but it is impossible to disable the overlay module as i have to scroll down the screen to disable it in the modules page.
I can scroll if i use an external device (scroll wheel of the mouse) DUH!

This is a big issue for me as i use my notebook and don't have scrolling options enabled on my touchpad

2) Does the overlay need to be enabled by default??

CommentFileSizeAuthor
#11 overlaywebkitscrollbar[2].patch1.12 KBvm
#9 overlaywebkitscrollbar[1].patch1.12 KBvm
#4 overlaywebkitscrollbar.patch1.12 KBcasey

Comments

vm’s picture

vm commented

isn't this disbaled by default in the minimal drupal install?

nvanhove’s picture

nvanhove commented

I have the same problems. Scrolling works on Firefox, but not on Google Chrome.
I'm using the Chrome Dev Channel, 4.0.266.0.

aspilicious’s picture

aspilicious commented

I used the normal one, I tought the minimal lacked some features but its just the number of features that are preinstalled...
Interesting that the overlay is seen as something most of the users use...

casey’s picture

casey commented
Status: Active » Needs review
StatusFileSize
new overlaywebkitscrollbar.patch1.12 KB

This is a webkit issue.

http://dev.jqueryui.com/ticket/4671
https://bugs.webkit.org/show_bug.cgi?id=19033

Patch makes it work for us.

aspilicious’s picture

aspilicious commented

Nice fix!
Who commit this to head?

Im gonna try learning to make my own patches after my exams...

Bojhan’s picture

Bojhan commented
Status: Needs review » Reviewed & tested by the community

Tried it out and seems it fixed it.

aspilicious’s picture

aspilicious commented

check check double check...
It works indeed...
but its lagging a tiny bit...
good for now

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

The code comment is great, but it fails to explain _why_ we are doing this. Could be tweaked a bit for those who don't have the context. Can we take a shot at extending or reworking the documentation a bit?

vm’s picture

vm commented
StatusFileSize
new overlaywebkitscrollbar[1].patch1.12 KB

Here's my crack at adding the context per #8

Essentially I combined and reworded the first two sentences which may address Dries concern with context.

Casey, I'm not going to mark this needs review. Please take a look and double check that I've properly addressed context concern in #8.

+  // Unbind the mousedown handler installed by ui.dialog itself.
+  // The handler disables the vertical scroll bar in Chrome & Safari.

I altered to read:

+  // Unbind the mousedown handler installed by ui.dialog because the handler interferes with use of the scroll bar in Chrome & Safari.
aspilicious’s picture

aspilicious commented

Wasn't there an 80 character a line rule?

vm’s picture

vm commented
StatusFileSize
new overlaywebkitscrollbar[2].patch1.12 KB

erp, yep thanks.

changed:

+  // Unbind the mousedown handler installed by ui.dialog because the handler interferes with use of the scroll bar in Chrome & Safari.

to:

+  // Unbind the mousedown handler installed by ui.dialog because the
+  // handler interferes with use of the scroll bar in Chrome & Safari.
casey’s picture

casey commented

This is also needed for the click event, so I included this patch into patch in #31 of #668104: Make overlay respect other click handlers.

casey’s picture

casey commented
Status: Needs work » Fixed

Ok that patch landed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.