Hi all!
First of all, thanks for great module! Secondly, sorry for my English, it's poor, but I'll try to be clear.
I'm using FAQ module with "Clicking on question opens/hides answer under question" page layout and "Show "expand / collapse all" links for collapsed questions" option turned on.
When I go to the faq page and click "Expand all" link, my browser (Opera 10.10) jumps to <div id="faq-expand-all"> (i. e. the page moves up and the link "Collapse all" appears at the top of the screen). This happens because Opera (I'm not sure about other browsers) treats tags with id attribute as a named anchor (as if it was <a name="faq-expand-all"> instead of <div id="faq-expand-all">), so the link <a href="#faq-expand-all"> refers to <div id="faq-expand-all">, and subsequenly, when I click on <a href="#faq-expand-all">, Opera jumps to <div id="faq-expand-all">.
I think this behavior is not optimal: the jump is too sharp, it doesn't look nice, it may confuse visitors, and it may be unwanted to those of them, who prefer to scroll page up and down themselves. To avoid this unpleasant jumps, I've made some replacements:
1) in file faq.module, line 1448: <div id="faq-expand-all"> ---> <div class="faq-expand-all">;
2) in file faq.css, lines 51, 55 and 56 and in file faq.js, lines 191, 192, 195, 197, 207 and 209: #faq-expand-all ---> .faq-expand-all.
After these replacements the module works fine and no jumps occur when clicking on "Expand all" link. Maybe you should make respective corrections and include them to the next stable release? (Of course, after thorough testing with various browsers etc.)
Thanks, and happy forthcoming new year! :)
Comments
Comment #1
stella commentedFixed
Comment #3
stella commentedReleased in 6.x-1.12.