related issue: http://drupal.org/node/635480

Other modules that are indexing documents based on nodes may want to use hook_apachesolr_update_index(), e.g. to get nodeaccess info appended. By passing more params, we can let implementing modules better filter out any calls they don't care about.

CommentFileSizeAuthor
#5 apachesolr-666648-D5.patch5.06 KBclaudiu.cristea
#2 improve-hook-666648-2.patch3.36 KBpwolanin
#1 improve-hook-666648-1.patch3.04 KBpwolanin

Comments

pwolanin’s picture

pwolanin commented
Status: Active » Needs review
StatusFileSize
new improve-hook-666648-1.patch3.04 KB
pwolanin’s picture

pwolanin commented
Title: Make hook_apachesolr_update_index() more generic by taking a namespace and caller also » Make hook_apachesolr_update_index() more generic by taking a namespace param also
StatusFileSize
new improve-hook-666648-2.patch3.36 KB

I think caller is probably not so useful -KISS

pwolanin’s picture

pwolanin commented
Version: 6.x-1.x-dev » 6.x-2.x-dev
Status: Needs review » Patch (to be ported)

comitted to 6.x-1.x - not sure how 6.x-2.x compares atm - maybe only to be backported to 5.x?

robertdouglass’s picture

robertdouglass commented
Version: 6.x-2.x-dev » 5.x-2.x-dev

#666648 by pwolanin: Changed Make hook_apachesolr_update_index() more generic by taking a namespace param also.

The two branches are in sync as far as this patch goes. Applying to 6.2.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Patch (to be ported) » Fixed
StatusFileSize
new apachesolr-666648-D5.patch5.06 KB

Committed to DRUPAL-5--2, in #318124.

Patch attached.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.