Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I have coder integration with the test bot working, but currently it results in the following when run on Drupal core.
1,044 minor(s), 24 critical(s), and 3,611 normal(s)
I would like to remove all critical and normals from Drupal core before enabling coder reviews on qa.drupal.org. Some may be issues with coder itself that need to be fixed, others may be Drupal core issues. I want to reach that threshold so we can enable it, then we can worry about getting rid of minors via patches to core or better detection methods in coder etc.
Comments
Comment #1
boombatower CreditAttribution: boombatower commentedCore style review
I will update this with a list of issues:
Core
Coder
Comment #2
axyjo CreditAttribution: axyjo commentedDoes this issue count under style as well? #606526: [Needs rollback] Remove trailing whitespaces and add newlines at end of files
Comment #3
boombatower CreditAttribution: boombatower commentedComment #4
Garrett Albright CreditAttribution: Garrett Albright commentedAdding per axyjo's request in IRC:
#672268: Comment cleanup of includes/database/database.inc
Comment #5
boombatower CreditAttribution: boombatower commentedAdded link to qa.d.o style review.
Comment #6
boombatower CreditAttribution: boombatower commentedTalked with webchick and decided to push for this heavily in early 8.x cycle.
Comment #7
sunAwesome work, guys!
Comment #8
TravisCarden CreditAttribution: TravisCarden commentedSee #1518116: [meta] Make Core pass Coder Review.