When you change the workflow for a node using the workflow tab, actions that act on the node do not work correctly. The problem is that the actions are executed, but the node is saved again, overwriting any changes made.

I've attached a patch. I suspect it will break na_arbitrator, since I'm removing a line of code that seems to be there for the express purpose of making na_arbitrator happy.

Maybe that line should be changed to load and save the node instead of just saving it, but I don't know Drupal well enough to see if there's a better way.

CommentFileSizeAuthor
patch_48439 bytesduncf

Comments

merlinofchaos’s picture

merlinofchaos commented

The line should be removed; workflow_access can deal with updating on state change via hook_workflow, which is what it should've done originally, but I didn't think of that.

Tobias Maier’s picture

Tobias Maier commented
Status: Needs work » Reviewed & tested by the community

I think this means its ready to be commited...

jvandyk’s picture

jvandyk commented
Status: Reviewed & tested by the community » Fixed

Committed.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)