Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The contant VERSION, which is defined in drupal.module, is not updated to 4.7.1. It still points to 4.7.0.
Comment | File | Size | Author |
---|---|---|---|
#6 | versions-4.8.0.patch | 1.03 KB | rstamm |
#5 | versions.patch.txt | 1023 bytes | killes@www.drop.org |
Comments
Comment #1
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedthanks.
I guess we need to define a policy when this should b changed and to which value.
Does anybody else think it is weird this is defined in drupal.module? This won't be visible if the module is disabled...
Comment #2
Crell CreditAttribution: Crell commentedI agree. If this constant defines the version of the "core" system, then it should be in a permanently-enabled part of core. I'd say either system.module (which is always enabled) or common.inc makes the most sense for where it should live.
Could it be setup so that CVS would automagically update it to be the value of the current tag? (I'm not a CVS expert, so I don't know if that's feasible/easy/impossible.)
Comment #3
dwwkilles: +1 -- this is weird it lives in drupal.module. see also http://drupal.org/node/53894
crell: no, there's no (good) way to have cvs automatically insert the value from a tag like you propose. unfortunately, we just need the humans to remember to change this.
at my day job, part of the "release to-do list" of things that must be done when making a release is moving the version string from whatever version we just released to "x+1 pre-release". for example, once we released 6.7.19, we changed our version string constant to "6.7.20 pre-release". then, when we're finally getting ready to release 6.7.20 for real, we make a new branch for it (a step drupal probably won't want/need to do), change the version string to "6.7.20", tag that as the official release, and move on to the next one...
perhaps drupal should do something similar...
Comment #4
rstamm CreditAttribution: rstamm commentedI prefer system.module as the location.
The version number should work with version_compare(), http://de3.php.net/version_compare, and we should only use the special defined strings.
For 4.7 branch it's 4.7.2 dev and for the main 4.8 dev
Comment #5
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedapplied to 4.7, patch for cvs attached.
Comment #6
rstamm CreditAttribution: rstamm commentednow i am not sure if 4.8 dev is ok, may be 4.8.0 dev is better
killes patch inlcludes 4.8 dev and my 4.8.0 dev
Comment #7
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.
Comment #8
(not verified) CreditAttribution: commented