The contant VERSION, which is defined in drupal.module, is not updated to 4.7.1. It still points to 4.7.0.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

killes@www.drop.org’s picture

thanks.

I guess we need to define a policy when this should b changed and to which value.

Does anybody else think it is weird this is defined in drupal.module? This won't be visible if the module is disabled...

Crell’s picture

I agree. If this constant defines the version of the "core" system, then it should be in a permanently-enabled part of core. I'd say either system.module (which is always enabled) or common.inc makes the most sense for where it should live.

Could it be setup so that CVS would automagically update it to be the value of the current tag? (I'm not a CVS expert, so I don't know if that's feasible/easy/impossible.)

dww’s picture

killes: +1 -- this is weird it lives in drupal.module. see also http://drupal.org/node/53894

crell: no, there's no (good) way to have cvs automatically insert the value from a tag like you propose. unfortunately, we just need the humans to remember to change this.

at my day job, part of the "release to-do list" of things that must be done when making a release is moving the version string from whatever version we just released to "x+1 pre-release". for example, once we released 6.7.19, we changed our version string constant to "6.7.20 pre-release". then, when we're finally getting ready to release 6.7.20 for real, we make a new branch for it (a step drupal probably won't want/need to do), change the version string to "6.7.20", tag that as the official release, and move on to the next one...

perhaps drupal should do something similar...

rstamm’s picture

I prefer system.module as the location.

The version number should work with version_compare(), http://de3.php.net/version_compare, and we should only use the special defined strings.

If a part contains special version strings these are handled in the following order: dev < alpha = a < beta = b < RC < pl. This way not only versions with different levels like '4.1' and '4.1.2' can be compared but also any PHP specific version containing development state.

For 4.7 branch it's 4.7.2 dev and for the main 4.8 dev

killes@www.drop.org’s picture

Status: Active » Reviewed & tested by the community
FileSize
1023 bytes

applied to 4.7, patch for cvs attached.

rstamm’s picture

Version: 4.7.1 » x.y.z
FileSize
1.03 KB

now i am not sure if 4.8 dev is ok, may be 4.8.0 dev is better

killes patch inlcludes 4.8 dev and my 4.8.0 dev

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)