First of all, thanks for this great project!

I am trying to create a make file which will download the latest 3.x development snapshot of admin_menu but got an error saying about invalid version. Here's my make file:

core = 6.x
projects[] = drupal
projects[admin_menu][version] = 3.x-dev

I also tried using 3.x and even 6.x-3.x-dev as version string but they produced the same errors. I read the documentation but couldn't find any info on this.

A suggestion would be very appreciated.

CommentFileSizeAuthor
#2 drush_make_enable_dev_version_string.patch970 byteskong

Comments

dmitrig01’s picture

dmitrig01 commented

yeah, version parsing could be a bit better. try 3-dev

kong’s picture

kong commented
Title: How to specify DEV version? » Patch for downloading DEV version
Component: Documentation » Code
Category: support » bug
Status: Active » Needs review
StatusFileSize
new drush_make_enable_dev_version_string.patch970 bytes

That still doesn't do the trick. However, I took a peek at the $project['release_history']->releases->release array and figured something out:

The release object for admin_menu-6.x-3.0-alpha3 contains

[name] => admin_menu 6.x-3.0-alpha3
[version] => 6.x-3.0-alpha3
[tag] => DRUPAL-6--3-0-ALPHA3
[version_major] => 3
[version_patch] => 0
[version_extra] => alpha3
[status] => published
[release_link] => http://drupal.org/node/550878
[download_link] => http://ftp.drupal.org/files/projects/admin_menu-6.x-3.0-alpha3.tar.gz
[date] => 1250462403
[mdhash] => ca00ce1b53f3d6ac8d53773d9dd66378
[filesize] => 60772
. . .

And the release object for admin_menu-6.x-3.x-dev contains

[name] => admin_menu 6.x-3.x-dev
[version] => 6.x-3.x-dev
[tag] => DRUPAL-6--3
[version_major] => 3
[version_extra] => dev
[status] => published
[release_link] => http://drupal.org/node/373515
[download_link] => http://ftp.drupal.org/files/projects/admin_menu-6.x-3.x-dev.tar.gz
[date] => 1258200048
[mdhash] => eab33c9bd3bd7abd692d2c6e01aebfc9
[filesize] => 63809

The difference is that there is no [version_patch] attribute for DEV version. So I modified the code in drush_make.drush.inc and the make file above seems to work fine. Please see the attached patch below.

dmitrig01’s picture

dmitrig01 commented

Comitted - thanks~

dmitrig01’s picture

dmitrig01 commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.