There is a terminology mismatch when using the "Comment: In moderation" filter in the Views admin UI. When you add the filter to a View, it's described as follows:
Comment: In moderation
Whether or not the comment is currently in moderation.
But when you proceed to configure the filter, the option is worded backwards, like this:
Moderated:
o Yes
o No
Question #1, "Is this comment in moderation?" is the opposite of question #2, "Is this comment moderated?" Views presents you with question #2, then interprets your response as if you had answered question #1.
If you choose "Moderated = Yes", you are indicating that you want comments that have been moderated and approved. But Views interprets the "Yes" response to mean "In moderation = Yes", which matches unmoderated/unapproved comments.
The labelling should be consistent and use either "In moderation" or "Moderated" in both places.
Comments
Comment #1
dawehnerDo you want to make a patch out of it? You can help easy to make views better :)
Comment #2
joachim commentedThis issue could probably be combined with #594402: node and comment moderation UI texts are unclear.
Comment #3
joachim commentedClosing this as a duplicate; patch at the other issue addresses this too.