As seen in several issue whois_parse_url() is not perfect, and making this 100% is near impossible.
#490072: idn idna Internationalized Domain Names
#303833: Fix the url regular expression
#617994: Bug in looking up IP address
#490072: idn idna Internationalized Domain Names

Therefore I suggest to remove this check completely, or make it optional.

Upon form POST/redirect the new url should be run through check_url to filter out any evil stuff.

Comments

Gurpartap Singh’s picture

Gurpartap Singh commented

Parse function was actually supposed to convert full urls to just the domain.tld format.

It needs to be intelligent about a lot of aspects. Until this fix is developed, it'll be great if you want to remove the call to this function. :D

helmo’s picture

helmo commented
Status: Active » Fixed

I committed a change to reverse the way the match is made. In the new version only obviously wrong elements are removed.

The replacement function is called _whois_cleanup_address().

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.