I don't know if I'm the only one, but I thinks that the friend notification integration in the account/edit page should get an other weight.
I always set the weight = 10, so it will be displayed at the bottom of the page and not somewhere.
Furthermore I would put the form into a fieldset and change the dropdown into a checkbox.
I think this would fit better into the view of the whole account/edit page.
I still tried to do this, but I didn't get this fully functional till yet.
What do you think ?

CommentFileSizeAuthor
#3 flag_friend-friend_notification-649294-3.patch3.35 KBagileware
account-edit.jpg71.93 KBSyKce

Comments

sirkitree’s picture

sirkitree commented

I think you're free to manipulate this through your own custom module just fine and the default is also just fine.

I would be open to reviewing a patch though.

sirkitree’s picture

sirkitree commented
Status: Active » Closed (fixed)

closing due to inactivity - if a patch is provided, please reopen and i will review.

agileware’s picture

agileware commented
Status: Closed (fixed) » Needs review
StatusFileSize
new flag_friend-friend_notification-649294-3.patch3.35 KB

Here is a patch that does what the screenshot shows.

It also requires a database update because the current select field unusually uses 0 for yes and -1 for no, which is not compatible with a check box.
So the update just changes this to 1 for yes and 0 for no if the user has set the setting.

Patch works for both 6.x-1.x-dev and 6.x-1.0.

sirkitree’s picture

sirkitree commented

I don't think I really want to put this in. Thanks for the work, but I just don't want to be manipulating this.

sirkitree’s picture

sirkitree commented
Status: Needs review » Closed (won't fix)