I found a place where the weight for non-stored line items was null. Looking, I found that it was improperly set by an inline conditional assignment in uc_order_load_line_items().

CommentFileSizeAuthor
#1 648870_proper_set_of_line_items.patch620 byteshanoii

Comments

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
StatusFileSize
new 648870_proper_set_of_line_items.patch620 bytes

One line change, pretty obvious and easy to review.

tr’s picture

tr commented
Status: Needs review » Fixed

Yes indeed - that was put into uc_order.module in revision 1.12.2.32, which was the 6.x-2.0 release. I verified the logic against the previous revision to make sure this patch reflected the intent of the original author. I'm surprised it went unnoticed for so long. Thanks for the patch. Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.